Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to record the replays of the training #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mateusmatiazzi
Copy link

Just changed some parameters to utilize the record function of Pysc2. I also changed the ReadMe to show how the new flags works.

@@ -75,7 +82,10 @@ def main(argv):
sess_mgr = rvr.utils.tensorflow.SessionManager(sess, expt.path, args.ckpt_freq, training_enabled=not args.test)

env_cls = rvr.envs.GymEnv if '-v' in args.env else rvr.envs.SC2Env
env = env_cls(args.env, args.render, max_ep_len=args.max_ep_len)
env = env_cls(args.env, args.render,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break support for non-sc2 environments.
Can you add a general-purpose flag similar to render to base env class (e.g. call it monitor)? Simply ignore it in other envs for now.

Copy link
Owner

@inoryy inoryy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good except for the minor compatibility issue with other envs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants