Improve hover behavior on icons in codeHighlight blocks #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartv
approved these changes
Oct 6, 2023
17 tasks
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Oct 10, 2023
…(Issue #4916, PR #5172) # Description I tried to figure out which was the root cause of the problem, I changed the implementations a few times, removed elements but it's still not clear what caused the glitches. It only happens when the codeblocks contain a lot of information, impacting performance. Most of the glitching could be either related to the Tooltips (they have minimal glitches on the PF site on Firefox) combined with the styled components "´css" declaration. I removed any superficial wrapper/customization of elements. It does still glitch once in a while when clicking on the kebab-menu and then clicking outside of it multiple times. This might be resolved once the deprecated version of the kebab menu is updated. But since I've been tackling that in another ticket, I kept it separated. https://github.com/inmanta/web-console/assets/44098050/ea1dcce3-af45-4875-b0f9-923710ca350e
|
Merged into branches iso6, master in 0d253a4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to figure out which was the root cause of the problem, I changed the implementations a few times, removed elements but it's still not clear what caused the glitches. It only happens when the codeblocks contain a lot of information, impacting performance. Most of the glitching could be either related to the Tooltips (they have minimal glitches on the PF site on Firefox) combined with the styled components "´css" declaration. I removed any superficial wrapper/customization of elements.
It does still glitch once in a while when clicking on the kebab-menu and then clicking outside of it multiple times. This might be resolved once the deprecated version of the kebab menu is updated. But since I've been tackling that in another ticket, I kept it separated.
hover-issue-resolution-details-page.mp4