-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/modify inmanta install guide #2869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
||
OR | ||
|
||
2. Get the source from `our github page <https://github.com/inmanta/inmanta-dashboard/releases>`_ on the right and under `Assets`, you will see the source. Next, build and install the dashboard. For this you need to have yarn and grunt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this part, using the pre-built npm is easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bart: wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I go about it? keep it or remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the prebuilt version
Co-authored-by: Wouter De Borger <wouter.deborger@inmanta.com>
Co-authored-by: Wouter De Borger <wouter.deborger@inmanta.com>
I would like arnaud to have a look at this as well, he has cleaned up these instructions before and has a much better eye for this than me |
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
docs/Makefile
Outdated
@@ -56,7 +56,6 @@ clean: | |||
-rm -rf $(PNGs) | |||
|
|||
html: openapi latexpdf | |||
cp $(BUILDDIR)/latex/inmanta.pdf $(SOURCEDIR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has to stay, even if I'm not sure why?
@arnaudsjs do you know why this is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It has to stay. A PDF version of the documentation is included in the HTML version of the documentation. This command moves the PDF from the output directory of the PDF build to the source directory of the HTML build.
@Pouriya-Inmanta make sure you use merge-tool and not merge it yourself |
Processing this pull request |
# Description * Revised Inmanta install guide for Debian
Failed to merge changes into iso3 due to merge conflict.Please open a pull request for these branches separately. |
Merged into branches master in da183d1 |
Not closing this pull request due to previously commented issues for some of the destination branches. Please open a separate pull request for those branches. You can safely close this pull request and delete the source branch. |
# Description * Revised Inmanta install guide for Debian
Processing #2889. |
Pull request opened by the merge tool on behalf of #2869
Merged in #2891 after resolving the conflict. |
Description