Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version conflict in Jenkins job for lsm quickstart #49

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Fix version conflict in Jenkins job for lsm quickstart #49

merged 3 commits into from
Jun 6, 2023

Conversation

arnaudsjs
Copy link
Contributor

@arnaudsjs arnaudsjs commented Jun 5, 2023 •
edited
Loading

This PR fixes two issues:

  • The --pre flag was missing when running against a development release. This resulted in a version conflict because pip was trying to match a stable version of inmanta-core against a dev version of inmanta-service-orchestrator.
  • This job was running against an ISO7 dev release by default, while we actually want to run against stable releases, because those are used by our end-users. I changed the job to run against the latest stable release of iso6 by default. I created a ticket (Run lsm-quickstart job against all ISO majors #50) to make sure this jobs takes into account all stable iso versions.

@arnaudsjs arnaudsjs requested review from wouterdb and FloLey June 5, 2023 06:50
@arnaudsjs arnaudsjs merged commit 42d014a into master Jun 6, 2023
@arnaudsjs arnaudsjs deleted the issue/fix-jenkins-build-lsm-quickstart branch June 6, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloLey FloLey FloLey approved these changes

@wouterdb wouterdb wouterdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaudsjs @wouterdb @FloLey