Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces location field support to the v2.x API by adding a Location class and integrating it into login registration functionality.
- Adds a new Location class with latitude, longitude, and collectedAt fields
- Integrates location field into RegisterLoginRequest and PostTransactionRequestBody
- Updates test coverage to include location field usage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/incognia/common/Location.java | New Location class with builder pattern for location data |
| src/main/java/com/incognia/transaction/login/RegisterLoginRequest.java | Adds location field to login request model |
| src/main/java/com/incognia/transaction/PostTransactionRequestBody.java | Adds location field to transaction request body |
| src/main/java/com/incognia/api/IncogniaAPI.java | Maps location field from request to request body |
| src/test/java/com/incognia/api/IncogniaAPITest.java | Updates test to include location field usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f4b91da to
269673a
Compare
* Adding location API Field to the lib * Upgrade action/cache to v4
269673a to
054b612
Compare
pierreoria
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Brings location field to the v2.x
Checklist