Skip to content

feat: adds custom properties to web login request #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierreoria merged 1 commit into from
Jul 30, 2025
Merged

feat: adds custom properties to web login request #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/incognia/api/IncogniaAPI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ public TransactionAssessment registerWebLogin(RegisterWebLoginRequest request)
.sessionToken(request.getSessionToken())
.requestToken(request.getRequestToken())
.policyId(request.getPolicyId())
.customProperties(request.getCustomProperties())
.type("login")
.build();

Expand Down
2 changes: 2 additions & 0 deletions src/main/java/com/incognia/transaction/login/RegisterWebLoginRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.incognia.transaction.login;

import java.util.Map;
import lombok.AccessLevel;
import lombok.Builder;
import lombok.Getter;
Expand All @@ -13,6 +14,7 @@ public class RegisterWebLoginRequest {
String sessionToken;
String requestToken;
String policyId;
Map<String, Object> customProperties;

@Getter(AccessLevel.NONE)
Boolean evaluateTransaction;
Expand Down
6 changes: 5 additions & 1 deletion src/test/java/com/incognia/api/IncogniaAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,9 @@ void testRegisterWebLogin_whenDataIsValid(Boolean eval) {
String externalId = "external-id";
String requestToken = "request-token";
String policyId = "policy-id";
Map<String, Object> customProperties = new HashMap<>();
customProperties.put("string-property", "string-value");
customProperties.put("float-property", 12.345);

dispatcher.setExpectedTransactionRequestBody(
PostTransactionRequestBody.builder()
Expand All @@ -529,7 +532,7 @@ void testRegisterWebLogin_whenDataIsValid(Boolean eval) {
.addresses(null)
.paymentMethods(null)
.policyId(policyId)
.customProperties(null)
.customProperties(customProperties)
.build());
mockServer.setDispatcher(dispatcher);
RegisterWebLoginRequest loginRequest =
Expand All @@ -539,6 +542,7 @@ void testRegisterWebLogin_whenDataIsValid(Boolean eval) {
.evaluateTransaction(eval)
.requestToken(requestToken)
.policyId(policyId)
.customProperties(customProperties)
.build();
TransactionAssessment transactionAssessment = client.registerWebLogin(loginRequest);
assertTransactionAssessment(transactionAssessment);
Expand Down