Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vultr: update Ubuntu version due to deprecation of 16.04 #96

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

jsiebens
Copy link
Contributor

@jsiebens jsiebens commented Jul 6, 2021

Signed-off-by: Johan Siebens johan.siebens@gmail.com

Description

Update Ubuntu images to 18.04 for the Vultr provider

How Has This Been Tested?

Create the inlets exit node:

$ go run main.go create -p vultr --access-token "$VULTR_TOKEN"
Using provider: vultr
Requesting host: crazy-cray7 in LHR, from vultr
Host: 48732398, status: 
[1/500] Host: 48732398, status: none
[2/500] Host: 48732398, status: none
...
[204/500] Host: 48732398, status: active
inlets PRO TCP (0.8.3) server summary:
  IP: 136.244.64.63
  Auth-token: vQGanZLGBjleE4IacZc1TGDkL2c9JPImBotrclYl01DxC8ssKq2vLIRkwa1o8lVc
...

Connect client:

$ inlets-pro tcp client --url "wss://136.244.64.63:8123" \
>   --token "vQGanZLGBjleE4IacZc1TGDkL2c9JPImBotrclYl01DxC8ssKq2vLIRkwa1o8lVc" \
>   --upstream $UPSTREAM \
>   --ports $PORTS
2021/07/06 19:57:35 Starting TCP client. Version 0.8.3 - 205c311fde775723cf68b8116dacd7f428d243f8
2021/07/06 19:57:35 Licensed to: Johan Siebens <redacted>, expires: 85 day(s)
2021/07/06 19:57:35 Upstream server: localhost, for ports: 8000
inlets-pro client. Copyright Alex Ellis, OpenFaaS Ltd 2020
INFO[2021/07/06 19:57:35] Connecting to proxy                           url="wss://136.244.64.63:8123/connect"

How are existing users impacted? What migration steps/scripts do we need?

no impact

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests
    No unit tests exist for most other providers and there's not much logic.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you.

Could you also extract a variable so that:

const Ubuntu20_04_x64 = "387" is present? i.e. self-documenting code.

@alexellis
Copy link
Member

That const should be lowercase, I've just realised that I wrote that in error, it wouldn't need a capital letter (package scope)

Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
@jsiebens jsiebens force-pushed the vultr_ubuntu_2004 branch from dca3c3c to 84c9b81 Compare July 7, 2021 14:19
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexellis alexellis merged commit d1c28b8 into inlets:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants