Skip to content

Hide fallback choices after loading #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hide fallback choices after loading #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ink-engine-runtime/JsonSerialisation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,9 @@ static Choice JObjectToChoice(Dictionary<string, object> jObj)
choice.originalThreadIndex = (int)jObj ["originalThreadIndex"];
choice.pathStringOnChoice = jObj ["targetPath"].ToString();
choice.tags = JArrayToTags(jObj, choice);
if (jObj.ContainsKey("isInvisibleDefault")) {
choice.isInvisibleDefault = (bool)jObj["isInvisibleDefault"];
}
return choice;
}

Expand All @@ -624,6 +627,7 @@ public static void WriteChoice(SimpleJson.Writer writer, Choice choice)
writer.WriteProperty("originalChoicePath", choice.sourcePath);
writer.WriteProperty("originalThreadIndex", choice.originalThreadIndex);
writer.WriteProperty("targetPath", choice.pathStringOnChoice);
writer.WriteProperty("isInvisibleDefault", choice.isInvisibleDefault);
WriteChoiceTags(writer, choice);
writer.WriteObjectEnd();
}
Expand Down
30 changes: 30 additions & 0 deletions tests/Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,36 @@ This is default.
Assert.AreEqual("After choice\nThis is default.\n", story.ContinueMaximally());
}

[Test()]
public void TestFallbackChoicesHiddenAfterLoad()
{
Story story = CompileString(@"
- (start)
* [Choice 1]
* [Choice 2]
* -> fallback
- After choice
-> start

== fallback ==
This is fallback.
-> DONE
");

Assert.AreEqual("", story.Continue());
Assert.AreEqual(2, story.currentChoices.Count);
Assert.AreEqual("Choice 1", story.currentChoices[0].text);
Assert.AreEqual("Choice 2", story.currentChoices[1].text);

var savedState = story.state.ToJson();

story.state.LoadJson(savedState);

Assert.AreEqual(2, story.currentChoices.Count);
Assert.AreEqual("Choice 1", story.currentChoices[0].text);
Assert.AreEqual("Choice 2", story.currentChoices[1].text);
}

[Test()]
public void TestDefaultSimpleGather()
{
Expand Down