fix(dashboard): Ensures rounded bottom corners render correctly in dark mode

[dimaMachina]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 5747fdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@inkeep/agents-manage-ui	Patch
@inkeep/agents-api	Patch
@inkeep/agents-cli	Patch
@inkeep/agents-core	Patch
@inkeep/agents-manage-mcp	Patch
@inkeep/agents-sdk	Patch
@inkeep/ai-sdk-provider	Patch
@inkeep/create-agents	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
agents-api	Ready	Preview, Comment	Jan 22, 2026 9:23pm
agents-docs	Ready	Preview, Comment	Jan 22, 2026 9:23pm
agents-manage-ui	Ready	Preview, Comment	Jan 22, 2026 9:23pm

[claude]

Claude finished @dimaMachina's task —— View job

---

Code Review Complete

After analyzing this PR that fixes rounded bottom corners rendering in dark mode, here's my comprehensive architectural and engineering review:

Summary

This is a targeted fix that addresses a specific visual issue with rounded corners in dark mode by moving the overflow-hidden property to a higher level container and adjusting background styling patterns.

🔍 Technical Analysis

Changes Overview

1. layout.tsx:

   • Added overflow-hidden to SidebarInset component
   • Removed background styling and rounded corners from header
   • Changed main background from bg-muted/20 dark:bg-background to not-dark:bg-muted/20

2. page.client.tsx:

   • Removed rounded-b-[14px] from ResizablePanelGroup

🎯 Engineering Quality Assessment

✅ Strengths

• Targeted Fix: Addresses the specific issue without unnecessary scope creep
• Consistent Patterns: Uses existing not-dark: utility pattern found elsewhere in codebase
• Semantic CSS: The overflow-hidden placement at SidebarInset level makes architectural sense

⚠️ Areas for Consideration

1. Incomplete Implementation Pattern

• The fix removes rounded-b-[14px] from the agent page but leaves rounded-br-[14px] in /components/layout/sidepane.tsx:22
• This creates inconsistency in the rounded corner approach across components
• Recommendation: Verify that sidepane corners still render correctly in dark mode, or apply similar overflow fixes there

2. Background Styling Logic

// Before: explicit dark mode handling
'bg-muted/20 dark:bg-background'

// After: negated approach  
'not-dark:bg-muted/20'

• The not-dark: approach assumes dark mode should have no background
• This is less explicit than the previous dark mode handling
• Consideration: While functionally equivalent, explicit dark: variants are typically more maintainable

3. Missing Documentation of Root Cause

• The PR title mentions "dark mode" but the core issue appears to be overflow-hidden placement
• Recommendation: Consider expanding the comment to explain why overflow-hidden specifically fixes the dark mode rendering issue

4. Potential Side Effects

• Adding overflow-hidden to SidebarInset could affect other child components beyond rounded corners
• Recommendation: Test scrolling behavior, tooltips, dropdowns, and other overflow-dependent UI within the sidebar inset area

🏗️ Architectural Considerations

1. CSS Containment Strategy

• Moving overflow-hidden up the component hierarchy is architecturally sound
• This creates better containment boundaries for the rounded corner styling
• Aligns with the principle of applying overflow control at the appropriate container level

2. Theme Consistency

• The codebase already uses not-dark: pattern in theme-toggle.tsx:44
• However, explicit dark mode variants are more common throughout the codebase
• Consideration: Establish consistent theming patterns across the application

🔧 Specific Recommendations

Priority 1 - Verify Complete Fix

// Ensure this component also handles dark mode correctly
// /components/layout/sidepane.tsx:22
<div className="relative top-0 right-0 bg-background h-full flex flex-col rounded-br-[14px] group">

Priority 2 - Consider More Explicit Theming

// Current approach
'not-dark:bg-muted/20'

// Alternative (more explicit)  
'bg-muted/20 dark:bg-transparent'
// or
'bg-muted/20 dark:bg-background'

Priority 3 - Expand Documentation

// Consider more descriptive comment
// Ensures rounded corners render correctly by containing overflow at the appropriate level
className="overflow-hidden"

🧪 Testing Recommendations

• Test rounded corner rendering across light/dark themes
• Verify no regressions in sidebar scrolling behavior
• Check tooltip and dropdown positioning within the affected containers
• Ensure consistency between main layout and sidepane rounded corners

✅ Verdict

This is a well-targeted fix that addresses a specific visual bug with a logical architectural approach. The main concerns are ensuring complete consistency across all rounded corner implementations and verifying no side effects from the overflow-hidden placement.

Recommended Actions Before Merge:

1. Test sidepane rounded corners in dark mode for consistency
2. Verify no scrolling/overflow side effects in affected containers
3. Consider adding a changeset (as noted by the changeset bot)

---