add permit2 as submodule, organize files to folders#65
Merged
anna-carroll merged 4 commits intoanna/permit2from Jul 18, 2024
Merged
add permit2 as submodule, organize files to folders#65anna-carroll merged 4 commits intoanna/permit2from
anna-carroll merged 4 commits intoanna/permit2from
Conversation
anna-carroll
added a commit
that referenced
this pull request
Jul 20, 2024
* feat: permit2 for token flows * add permit2 as submodule, organize files to folders (#65) * forge install: permit2 * remove vendored contracts * move IOrders to interfaces/ * move permit2 to folder * break permit2 functionality into discrete contracts * fix: update witness encoding for EIP-712 compliance * refactor: generate witness as public field * minor refactor * snapshot * function visibility & ordering * test: permit2 flows * snapshot * remove TODOs * split batch and single helpers * split up passage/orders tests * unused import * snapshot * add expectCall * snapshot * feat: redo permit tests as mainnet fork --------- Co-authored-by: James Prestwich <james@prestwi.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.