feat: fill multiple Outputs at once #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
force-pushed
the
anna/multiple-fill
branch
from
27b03da to
5c9d060
Compare
anna-carroll
force-pushed
the
anna/multiple-fill
branch
from
5c9d060 to
6dde82f
Compare
anna-carroll
force-pushed
the
anna/multiple-fill
branch
from
6dde82f to
1a867b9
Compare
anna-carroll
commented
Jul 1, 2024
| /// @notice Send multiple Output(s) of Order(s). | ||
| /// @custom:emits OutputFilled for each output | ||
| /// @param outputs - The array of Outputs to fill. | ||
| function fill(uint256[] memory originChainIds, Output[] memory outputs) external payable { |
There was a problem hiding this comment.
so, if we merge this PR, we could do
(uint256[] memory originChainIds, Output[] memory outputs)- we could repurpose
chainIdin the Output struct - use it to betargetChainIdon the origin chain, andoriginChainIdon the target chain (this is probably confusing)
|
@prestwich overall i don't find this to be stylistically additive, even though the order initiation uses arrays |
if we don't write it, other people will. are we comfortable with that? |
Merged
|
closing in favor of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putting this in a separate branch for consideration