-
Notifications
You must be signed in to change notification settings - Fork 6
refactor: split Passage enter/exit from Orders #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i do think this is conceptually cleaner.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directionally I approve. seems there are some TODOs
note: ERC20 enters/exits are not specced yet, so i'm removing those functions from this PR for now: 9c6438a if we decide not to implement them, it would make more sense to remove the let's decide on ERC20 plan then ossify that event interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would delete the exit code, as we haven't specified this behavior, and we don't know if the code is appropriate for it
current PR TODO