Conversation
prestwich
force-pushed
the
prestwich/block-driver
branch
from
9da5cef to
25ed451
Compare
Evalir
reviewed
Aug 1, 2024
|
|
||
| let trevm = trevm.close_block().map_err(EvmErrored::err_into)?; | ||
|
|
||
| match driver.post_block_checks(&trevm) { |
Member
There was a problem hiding this comment.
I think we should mark this as a TODO too indicating it's a noop atm.
Evalir
approved these changes
Aug 1, 2024
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
LGTM, I like how each trait now handles an specific part of the system, and pushing generics to the functions instead of the traits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on higher-level traits to drive trevm instances through many txns in a single function call
BlockDriverandChainDrivertraitsSome significant refactoring to achieve this:
BlockContextgenerics have been moved to the functions involvedBlockContexterror is now generic overDbEvmNeedsFirstBlockandEvmNeedsNextBlockhave been collapsed toEvmNeedsBlockto simplify context handling. Separating them was a holdover from earlier designs where trevm would accumulate context info-
Trevm::errored()-
EvmErrored::err_into-
EvmErrored::map_errtake_context