-
Notifications
You must be signed in to change notification settings - Fork 0
fix: add parmigiana host genesis file, consolidate to 1 container #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
so a few things
|
|
its host, I can update the name accordingly |
|
this is for usage by the running node as part of startup (reth requirement not our code) its for the |
yes I understand the purpose. Given we already have a maintained version of this file, is there a way we can re-use that maintained version instead of maintaining a second version? |
|
that is the genesis for the rollup is it not? |
|
oh i see, how would I make that file available on the filesystem? wouldn't I need to do something a bit hacky like checkout that repo separately in this ci and pull it into the dockerfile? |
|
It feels much cleaner to keep the container deps in the same repo as the dockerfile |
|
I could move the dockerfile to node-components but then i'd have the inverse problem with building the binary for the container |
|
i'm going to approve this PR, but can you make a ticket to solution this more? we can likely modify node init to bypass that CLI flag and use a genesis from the package |
|
oh, dockerfile is still called "pecorino" |
|
no its not I deleted that file and the corresponding workflow |
|
oh yep dope |
Adds the genesis file for parmigian host and makes it available in the standard signet container so we don't have testnet 1-off containers to manage