fix(tracing): actually use span on permissioning #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not actually entering the span, so the logs show up pretty empty.
rswanson
approved these changes
Jul 2, 2025
Evalir
commented
Jul 2, 2025
| #[error( | ||
| "builder not permissioned for this slot: requesting builder {0}, permissioned builder {1}" | ||
| )] | ||
| NotPermissioned(String, String), |
There was a problem hiding this comment.
@prestwich you ended up being right here that the messages on this error should've been made more useful. This was merged but we can keep working on this on a new PR.
prestwich
reviewed
Jul 2, 2025
| return Err(BuilderPermissionError::NotPermissioned); | ||
| return Err(BuilderPermissionError::NotPermissioned( | ||
| sub.to_owned(), | ||
| self.current_builder().sub.to_owned(), |
There was a problem hiding this comment.
subs are not secrets right @rswanson
| @@ -187,6 +194,8 @@ where | |||
|
|
|||
| info!("builder permissioned successfully"); | |||
|
|
|||
| drop(guard); | |||
|
|
|||
| this.inner.call(req).await | |||
There was a problem hiding this comment.
should we instrument this future with the perms span?
|
ugh didn't see this was merged before commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not actually entering the span, so the logs show up pretty empty.