Skip to content

feat: private repo support for ecr push #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rswanson merged 2 commits into from
Dec 8, 2024
Merged

feat: private repo support for ecr push #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e7aa8
feat: private repo support for ecr push
rswanson Dec 6, 2024
ba97229
fix: ssh flag for docker to mount ssh agent in build container
rswanson Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ecr-build-and-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,27 @@ on:
description: 'Environment to deploy to'
required: true
type: string
requires-private-deps:
description: 'Requires private dependencies to be fetched, sets up ssh-agent'
required: false
default: false
type: boolean
secrets:
aws-ecr-repository:
description: 'ECR repository to push to'
required: true
aws-ecr-deployer-role-arn:
description: 'Role ARN to assume for ECR'
required: true
SSH_PRIVATE_KEY:
description: 'SSH private key for fetching private dependencies'
required: false
SSH_PRIVATE_KEY_2:
description: 'SSH private key for fetching private dependencies'
required: false
SSH_PRIVATE_KEY_3:
description: 'SSH private key for fetching private dependencies'
required: false

env:
CARGO_TERM_COLOR: always
Expand Down Expand Up @@ -56,6 +70,14 @@ jobs:
- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v2
- name: Setup ssh-agent
if: ${{ inputs.requires-private-deps == true }}
uses: webfactory/ssh-agent@v0.9.0
with:
ssh-private-key: |
${{ secrets.SSH_PRIVATE_KEY }}
${{ secrets.SSH_PRIVATE_KEY_2 }}
${{ secrets.SSH_PRIVATE_KEY_3 }}
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Setup Docker Metadata
Expand All @@ -78,6 +100,9 @@ jobs:
context: .
cache-from: type=local,src=/tmp/.buildx-cache
cache-to: type=local,dest=/tmp/.buildx-cache-new,mode=max
ssh: default
env:
CARGO_NET_GIT_FETCH_WITH_CLI: true
- # Temp fix
# https://github.com/docker/build-push-action/issues/252
# https://github.com/moby/buildkit/issues/1896
Expand Down