Typescript conversion of parse5 package #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hefty one. The parse5 package has been moved to typescript, other than tests. A small summary: - `@typescript-eslint` introduced for the parse5 package - Mixins reworked slightly to be strongly typed - Default tree adapter is an instance of a class now - A few weeks worth of other changes to get it building
|
Hi @43081j, great effort! I have already completed a TS port at https://github.com/parse5/parse5-fork, plus a lot of other quality of life improvements & bug fixes. I've invited you to the org in the past, let me know if you're interested in using that as a starting point. Quite unfortunate that conversion efforts were duplicated here :/ |
|
yeah very unfortunate. its in a single commit really, which was started a few months ago so i doubt there was any chance we would've crossed paths. there's a fair amount of stronger types in my branch than in yours, i've seen. if anything, i'd suggest you read through mine. meanwhile i'll have a think about what should happen with this as i feel like both branches have their good parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other packages have been left as-is.
I am not expecting this PR to ever land, it is more here as reference (or something?) until we decide what to do about the path forward (potentially a fork).
@fb55 sorry it took me so long to respond to you in the other PR. this is what I was busy doing meanwhile. it'll need somewhere to live, so we should find a place to discuss this since you seem the most willing to maintain a fork.