-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use domhandler node interface in htmlparser2 adapter #327
Conversation
Tests are passing locally. |
Looks great 👌 You might have to update the package-lock file for CI to pass. A |
I guess I could but it's in gitignore for some reason |
Btw do you use npm 7 or 6? |
The lock file is has a version of 1, which is npm 6. |
Caz adapter package does not have package-lock.json. And root one does not reflect workspaces. Yarn would work here. Probably npm 7 as well but I never tried it. |
Ah, perhaps the problem is that travis uses npm 7 :) |
True, very interesting. @inikulin can hopefully provide some background infos. |
Travis changed their oss plan recently. A lot of builds are screwed up and take hours to finish. Perhaps they forces users to migrate to github actions and leave them alone. |
I found out yesterday that all that's needed is a migration from Travis' .org offering to their .com domain. Builds seem to be fast again once that's done. |
@inikulin Any feedback on this change? I'd love to get out a new release of cheerio, and this is currently blocking. |
@fb55 i am at present doing a large refactor i will implement that directly now into the new version |
@frank-dspeed Very cool, let me know if you need any help! |
Hi folks. Unfortunately I don't have enough time anymore to actively support the project. So, would love to see more co-maintainesr. @fb55 maybe you'd like to take over the project? Would appreciate if you spread the word and contact me via ivan@nikulin.engineering |
@inikulin Thanks for your offer — I am happy to take over the project! I've sent you an email a few weeks back; my one ask would be to transfer the project to the @cheeriojs org (or its own org), to encourage others to contribute to the project. Please let me know if there is anything I can do to make this easier for you! |
Thanks again for opening this @TrySound! Took a while to get this merged, but we are finally there. |
Co-authored-by: Felix Böhm <188768+fb55@users.noreply.github.com>
Ref cheeriojs/cheerio#1506
cc @fb55 @inikulin