(NOT READY) Declarative shadow dom #1639
Open
+266
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't tested yet, but this adds support for declarative shadow roots (closing #1469).
A couple questions for this approach:
.contentproperty of the template being parsed, this entails adding the.setTemplateContentForDeclarativeShadowRootParsingmethod as unlike.setTemplateContentwe don't want implementations to change the shadow root's host to the parsing template (like JSDOM does). Is there some easy way in the parser we could avoid this trick and just put the shadow root on the parsing stack somehow?