don't sort keys #11
don't sort keys #11
Conversation
no need for a special case for osx test here any more
| @@ -75,7 +75,7 @@ JSON.keys() { | |||
| JSON.object "$@" | | |||
| cut -f1 | | |||
| sed "s/^\///; s/\/.*//" | | |||
| sort -u | |||
| uniq | |||
There was a problem hiding this comment.
Having just uniq here makes it look like it is assumed that the keys are already sorted. Because uniq only removes same values on adjacent lines. It would actually make more sense to either keep the sort -u, or drop it completely and just assume the user knows what he's doing. Since JSON is position independent, I'd vote to keep the sort -u in place and make it easier for the user.
There was a problem hiding this comment.
@dolik-rce good point. There might be situations (depending on how put would be implemented, for example) where they keys are not on adjacent lines.
I guess that why I'd put in the sort in the first place ;-)
|
I think it would be better to fix the test. Since the difference on OS X is probably due to different locale setting, the simplest way to correct the test would be to make sure same locale is used. I'd just change the expected value to |
|
@dolik-rce thanks, good idea! |
|
Created a new PR with the suggestion from @dolik-rce |
I think it's not necessary to sort the keys.
Also then there's no need for a special case for osx test here any more