Not working with `git worktree` repo

[vjpr]

git subrepo pull packages/public
git-subrepo: Command failed: 'git worktree add .git/tmp/subrepo/packages/public subrepo/packages/public'.
fatal: could not create leading directories of '.git/tmp/subrepo/packages/public/.git': Not a directory

This is because when you create a git worktree, .git is a file containing a link to the primary gitdir.

[grimmySwe]

Hi @vjpr, do you have some more examples for this? I am not really sure how to reproduce this as it reported now.

[vjpr]

@grimmySwe

# Create repo with subrepo
git init
touch readme.md
git commit -am "First"
git subrepo clone <any-repo> packages/public

# Create a worktree of this repo
git worktree add ../foo foo
cd ../foo

# Try to pull
git subrepo pull packages/public

git-subrepo: Command failed: 'git worktree add .git/tmp/subrepo/packages/public subrepo/packages/public'.
fatal: could not create leading directories of '.git/tmp/subrepo/packages/public/.git': Not a directory
Preparing worktree (checking out 'subrepo/packages/public')

---

Issue is $GIT_TMP expects .git to be a directory, but if you run git subrepo pull from a worktree, then .git is a file.

Workaround

Use GIT_TMP=.git-tmp.

Fix

To nest inside .git you would need some logic to find the main worktree. But you probably always want to have a worktree-specific tmp dir for subrepo.

But then you need the user to add .git-tmp to their gitignores.

Maybe using GIT_TMP=.git-subrepo would be better...

[grimmySwe]

Thanks for your example, I'll label this as enhancement now, supporting the nested logic using git-subreo in a worktree.