Add deferred cleanup option for autoscaling tests #314
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new variable (default: true) that controls when autoscaling stack cleanup runs. When set to false, cleanup is deferred to an always block in the playbook, ensuring resources are properly torn down even if tests fail. Changes: - Add telemetry_autoscaling_cleanup variable to role defaults - Make cleanup task conditional on telemetry_autoscaling_cleanup flag - Move cleanup to always block in run_autoscaling_tests.yml playbook - Document new variable in role README Assisted-by: claude
elfiesmelfie
force-pushed
the
autoscaling_cleanup
branch
from
c804f6d to
27f3be5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f1044c30d1ed412488608a1d20bdd69f ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 35m 46s |
|
This does fix the test errors that were showing up in the combined telemetry/watcher tests. |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new variable (default: true)
that controls when autoscaling stack cleanup runs. When set to false, cleanup is deferred to an always block in the playbook, ensuring resources are properly torn down even if tests fail.
Changes:
Assisted-by: claude