feat!: Refactor ACM module to accept provider aliases for cross-account DNS records. #25
+660
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-infra
force-pushed
the
fix/module-dependency-error
branch
from
d2e848e to
9f9545b
Compare
examples/complete/main.tf
Outdated
| alias = "cross_account_provider" | ||
| region = var.region | ||
|
|
||
| dynamic "assume_role" { |
There was a problem hiding this comment.
let's not have this logic here, keep it simple please
Contributor
Author
There was a problem hiding this comment.
This is the example main.tf.
So we have removed the provider code from our modules.
There was a problem hiding this comment.
No, even with example it should be simpler. This is what others will use as reference.
| version = "~> 6.0" | ||
| source = "hashicorp/aws" | ||
| configuration_aliases = [ | ||
| aws, |
Contributor
Author
There was a problem hiding this comment.
We are giving aws version in root versions file.
rahul-infra
force-pushed
the
fix/module-dependency-error
branch
from
fba8daa to
f30f19b
Compare
formatted terraform file. terraform-docs: automated action Updated examples for same account and cross account. Added line enter. Updated readme for same account and cross account examplefile. terraform-docs: automated action updated root readme file.
rahul-infra
force-pushed
the
fix/module-dependency-error
branch
from
1b4aa65 to
60ad05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.