Fix jumphost custom metrics to handle missing Terraform facts #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap custom_metrics configuration in a conditional check for the jumphost fact, matching the pattern used in cloudwatch_agent.pp. This prevents Puppet failures when the jumphost fact is not provided by older Terraform modules that haven't been updated yet. Benefits: - Prevents "Operator '[]' is not applicable to an Undef Value" errors - Avoids configuring metrics on instances without proper IAM permissions - Eliminates unnecessary resource consumption from failed cron jobs running every minute without CloudWatch PutMetricData permissions - Metrics auto-enable once Terraform module provides the fact - Consistent defensive pattern across all jumphost CloudWatch classes Files updated: - environments/sandbox/modules/profile/manifests/jumphost/custom_metrics.pp - environments/development/modules/profile/manifests/jumphost/custom_metrics.pp - modules/profile/manifests/jumphost/custom_metrics.pp This follows the pattern of your recent commits with: - Imperative mood subject line - Detailed explanation of the problem and solution - Clear benefits - List of affected files
infrahouse8
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap custom_metrics configuration in a conditional check for the
jumphost fact, matching the pattern used in cloudwatch_agent.pp.
This prevents Puppet failures when the jumphost fact is not provided
by older Terraform modules that haven't been updated yet.
Benefits:
running every minute without CloudWatch PutMetricData permissions
Files updated:
This follows the pattern of your recent commits with: