Skip to content

Add fargate support #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2025
Merged

Add fargate support #165

merged 4 commits into from
May 13, 2025

Conversation

tomduckering
Copy link
Contributor

require service to use fargate with the fargate boolean variable.

generic cpu and memory parameters added which are first class parameters
in the task definition for fargate tasks. These will also
be respected when templating task definitions for non fargate tasks.

@tomduckering
Add fargate support
3d1e803 
require service to use fargate with the `fargate` boolean variable.

generic cpu and memory parameters added which are first class parameters
in the task definition for fargate tasks. These will also
be respected when templating task definitions for non fargate tasks.
tobyclemson
tobyclemson reviewed May 9, 2025
View reviewed changes
@tobyclemson
Copy link
Member

I think you'll also need to add:

  • service_task_runtime_platform_operating_system_family
  • service_task_runtime_platform_cpu_architecture
    as it looks like they are required when the FARGATE compatibility is required.

@tobyclemson
Copy link
Member

See here: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ecs_task_definition#runtime_platform

@tomduckering tomduckering marked this pull request as draft May 9, 2025 08:38
@tomduckering
Use more consistent naming for variables
dbfb447
@tomduckering
Improve the testing
6058a54 
test for default and when values are specified.
@tomduckering
Add Fargate support
f54550e 
with tests - unit and integration.
@tomduckering tomduckering marked this pull request as ready for review May 13, 2025 16:34
@tomduckering tomduckering merged commit 620510c into main May 13, 2025
@tomduckering tomduckering deleted the support_fargat branch May 13, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobyclemson tobyclemson tobyclemson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomduckering @tobyclemson