-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/ui(directions): directions component refactor #1685
Open
LAMM26
wants to merge
5
commits into
next
Choose a base branch
from
directions-refactor
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Premier tests
- À l'ajout d'un premier point , on déclanche la requête et on obtient une erreur. Tout comme au deuxième
- Modifier la coordonée directement dans l'input ne change pas la position sur la carte et ne trigger pas une nouvelle recherche d'itinéraire.
Proposition:
- Est-ce qu'on pourrait afficher les boutons de drag et de supression seulement lorsqu'on hover la ligne avec le curseur?
- Avoir au moins un point de départ et d'arrivée avant de proposer d'ajouter un point intermédiaire?
- Google Map, au lieu d'ajouter un point intermédiaire, ils utilisent ajouter une destination et il positionne le bouton à la fin.
packages/geo/src/lib/directions/directions-buttons/directions-buttons.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/directions/directions-buttons/directions-buttons.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/directions/directions-buttons/directions-buttons.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/directions/directions-results/directions-results.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/directions/directions-results/directions-results.component.html
Outdated
Show resolved
Hide resolved
alecarn
approved these changes
Nov 5, 2024
@pelord si jamais tu veux jeter un oeil, des améliorations aux UI de direction |
LAMM26
force-pushed
the
directions-refactor
branch
from
November 11, 2024 18:53
ff78131
to
ec6b5e9
Compare
LAMM26
force-pushed
the
directions-refactor
branch
from
November 11, 2024 20:03
9914cc7
to
9ca3a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
After having deployed the private routing option and having multiple feedback from different users on the component, many features were not clear or unknown to many of them and/or the UI was not user-friendly.
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: