Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23 - Switch link back slash to forward slash #28

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

jason-fox
Copy link
Collaborator

@jason-fox jason-fox commented Nov 20, 2023

Fixes #23, which an issue when:

  1. Building an index on Windows.
  2. Building an index with deeply embedded folders.

slashes in link and l are interpreted as escape characters.

@jason-fox jason-fox added the bug Something isn't working label Nov 20, 2023
Copy link
Owner

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

Would a similar change fix infotexture/dita-bootstrap#141?

@infotexture
Copy link
Owner

Squashing to omit reverted commits.

@jason-fox
Copy link
Collaborator Author

I believe so. @lakokkonen has supplied the basis for a fix already, just need to apply it:

I was able to switch the backslashes to forward ones with this monstrosity: <xsl:value-of select="translate( replace($FILEDIR,'[^\\]+','..'), '', '/' )"/>

@infotexture infotexture merged commit 6b03068 into infotexture:develop Nov 20, 2023
1 check passed
@infotexture
Copy link
Owner

Yep, saw that there. The solution here looks simpler though.

infotexture added a commit that referenced this pull request Feb 7, 2024
* release/5.3.4: (21 commits)
  Bump plug-in version attribute to 5.3.4
  Bump prettier from 3.1.1 to 3.2.5 (#42)
  Migrate Husky to v9
  Bump husky from 8.0.3 to 9.0.10 (#41)
  Use depend.preprocess.post endpoint (#40)
  Bump lint-staged from 15.2.0 to 15.2.1 (#37)
  Convert Prettier runtime config to YAML
  Bump prettier from 3.1.0 to 3.1.1 (#36)
  Preserve unstaged changes with the --no-stash flag
  Bump lint-staged from 15.0.2 to 15.2.0 (#35)
  Bump prettier from 3.0.3 to 3.1.0 (#33)
  Fix close button (#31)
  Reverse backslashes for Windows Filepath (#30)
  Add Greek language (#29)
  Fix #23 - Switch link backslash to forward slash (#28)
  Bump @prettier/plugin-xml from 3.2.1 to 3.2.2 (#27)
  Bump lint-staged from 14.0.1 to 15.0.2 (#26)
  Bump lunr-languages from 1.13.0 to 1.14.0 (#25)
  Bump actions/setup-node from 3 to 4 (#24)
  Bump actions/checkout from 3 to 4 (#22)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trying to implement ldita-bootstrap.lunr in the bootstrap ditaot plugin but facing some error
2 participants