1408 support array column type in recordedit #2340
Conversation
…into 1408-support-array-column-type-in-recordedit
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…into 1408-support-array-column-type-in-recordedit
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…into 1408-support-array-column-type-in-recordedit
…//github.com/informatics-isi-edu/chaise into 1408-support-array-column-type-in-recordedit
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…408-support-array-column-type-in-recordedit
There was a problem hiding this comment.
Thank you for the recent changes. It works now and the array inputs are aligned properly inside the "select all/some" panel. It seems like you missed the empty input case. The code is still sending [] when you leave the inputs empty.
I pulled latest master and resolved the conflicts. This change updates a lot of different dependencies, so make sure to do make deps-test before deploying/testing.
The last time I didn't pay too much attention to your tests, but now looking at it, I can't imagine that they would pass for you. The selectors that you used seem invalid to me. You're also directly using selectors. Please spend more time on testing. And this time around make sure they are passing and everything is ready.
| display: flex; | ||
| flex-direction: row; | ||
| gap: 5px; | ||
| [class*='input-switch-container'] { |
There was a problem hiding this comment.
It ensures that the input field takes all the available width. This is how it looks with and without this rule.
…//github.com/informatics-isi-edu/chaise into 1408-support-array-column-type-in-recordedit
…408-support-array-column-type-in-recordedit
- refactored the array-field comp a bit to avoid eslint max length warning - fix a bug in date-time-field that was avoiding submit - fix test cases
…//github.com/informatics-isi-edu/chaise into 1408-support-array-column-type-in-recordedit
we were blindly passing output of register to InputSwitch which caused the "forward ref" issue. so intead of forwarding ref on InputSwitch, I just changed the array-field implementation to not pass the reference as we don't need it and not using it.
…408-support-array-column-type-in-recordedit
Implemented array input fields