Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate JSON-RPC errors through the Rust subscription #929

Merged
merged 11 commits into from
Jul 19, 2021
Merged

Propagate JSON-RPC errors through the Rust subscription #929

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
99d6f30
Propagate JSON-RPC errors through the Rust subscription
romac Jul 15, 2021
be883f6
Fix clippy warnings
romac Jul 16, 2021
ffb2e66
Add .changelog entry
romac Jul 16, 2021
8ce1d10
Update .changelog/unreleased/improvements/932-propagate-json-rpc-erro…
romac Jul 16, 2021
7fae0e3
Update rpc/src/client/transport/router.rs
romac Jul 16, 2021
0d614ed
Specify default value for `tendermint::block::Size` (#931)
romac Jul 16, 2021
6b3c074
Remove subscription id to query index in `SubscriptionRouter`
romac Jul 19, 2021
cb90aa2
Introduce type aliases for subscription ids and queries
romac Jul 19, 2021
c8d77ae
Fix dead code warnings when `websocket` feature is disabled
romac Jul 19, 2021
27767b4
Update .changelog/unreleased/bug-fixes/930-newblock-event-parse.md
thanethomson Jul 19, 2021
aaa9df4
Merge branch 'master' into romac/ws-errors
thanethomson Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update rpc/src/client/transport/router.rs 
Co-authored-by: Thane Thomson <thane@informal.systems>
  • Loading branch information
@romac @thanethomson
romac and thanethomson authored Jul 16, 2021
commit 7fae0e3eaff2ed26ffa099456578bb80182d527e
1 change: 1 addition & 0 deletions rpc/src/client/transport/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ impl Default for SubscriptionRouter {
pub enum PublishResult {
Success,
NoSubscribers,
// All subscriptions for the given query have disconnected.
AllDisconnected(String),
}

Expand Down