Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: Align TryFrom impls for Duration with prost-types #1456

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

romac
Copy link
Member

@romac romac commented Aug 8, 2024

No description provided.

Copy link
Collaborator

@tony-iqlusion tony-iqlusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this probably makes more sense than supporting negative durations, at least unless there's an actual use for them in the Cosmos ecosystem somewhere

@tony-iqlusion tony-iqlusion merged commit f1ebab8 into main Aug 8, 2024
23 checks passed
@tony-iqlusion tony-iqlusion deleted the proto/try-from-duration-error branch August 8, 2024 19:05
@tony-iqlusion
Copy link
Collaborator

@romac with this merged I can confirm I can upgrade cosmos-sdk-proto / cosmrs 🎉

@romac
Copy link
Member Author

romac commented Aug 8, 2024

Glad to hear! Will do a release tomorrow then

@tony-iqlusion
Copy link
Collaborator

@romac it'd be good if you can get #1457 in as well

@romac
Copy link
Member Author

romac commented Aug 8, 2024

Will do! Apologies for the oversight and thanks for all the PRs 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants