Avoid enabling flex-error/eyre_tracer feature #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t enable flex-error/eyre_tracer feature in crates which don’t use eyre directly. This allows customers depend on say tendermint crate without having to pull in eyre crate. This is useful because eyre uses mutable static variables (specifically HOOK variable) which is incompatible with some blockchain runtimes.
romac
approved these changes
Oct 23, 2023
|
Good catch! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t enable flex-error/eyre_tracer feature in crates which don’t use
eyre directly. This allows customers depend on say tendermint crate
without having to pull in eyre crate. This is useful because eyre
uses mutable static variables (specifically HOOK variable) which is
incompatible with some blockchain runtimes.
.changelog/