Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump MSRV to 1.71.1 #1119

Merged
merged 35 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
dfaa738
bump msrv to 1.71.1
rnbguy Mar 9, 2024
513594c
add ci check
rnbguy Mar 9, 2024
bbe76bf
rm windows
rnbguy Mar 9, 2024
e022acf
refactor msrv check
rnbguy Mar 9, 2024
28947f6
use cargo-msrv
rnbguy Mar 9, 2024
44c64d0
add names to steps
rnbguy Mar 9, 2024
cd44a48
apply clippy suggestions
rnbguy Mar 9, 2024
b640135
rm redundant import
rnbguy Mar 9, 2024
568a5a2
clippy::use_self
rnbguy Mar 10, 2024
f5c12ff
clippy::cast_lossless
rnbguy Mar 10, 2024
0544df3
clippy::match_same_arms
rnbguy Mar 10, 2024
0a1a708
apply clippy suggestions
rnbguy Mar 10, 2024
aff9942
reuse old var
rnbguy Mar 10, 2024
fcda368
refactor old code
rnbguy Mar 10, 2024
38b5371
badge for license, version, downloads
rnbguy Mar 10, 2024
665fc15
rm broken tokei loc badge
rnbguy Mar 10, 2024
e065529
add changelog
rnbguy Mar 11, 2024
2084711
clippy::derive_partial_eq_without_eq
rnbguy Mar 11, 2024
ac7c4ab
clippy::string_lit_as_bytes
rnbguy Mar 11, 2024
cb32ce8
clippy::empty_line_after_doc_comments
rnbguy Mar 11, 2024
604c69e
clippy::cloned_instead_of_copied
rnbguy Mar 11, 2024
8587c28
clippy::unreadable_literal
rnbguy Mar 11, 2024
8ba7ad1
clippy::single_match_else
rnbguy Mar 11, 2024
e1c14a1
expect over unwrap
rnbguy Mar 11, 2024
91d2c68
use let-else
rnbguy Mar 11, 2024
5b221d4
use ok_or_else
rnbguy Mar 11, 2024
0f8001d
propagate None
rnbguy Mar 11, 2024
6acf412
clippy::match_same_arms
rnbguy Mar 11, 2024
b50d08b
return precise error
rnbguy Mar 11, 2024
4b0f27f
rm downcast in favor of let-else
rnbguy Mar 11, 2024
1e90a9b
chore: add unclog for 1101 + move 1118 under breaking-changes
Farhad-Shabani Mar 11, 2024
c7beb71
add msrv in clippy config
rnbguy Mar 12, 2024
332c5de
update changelog
rnbguy Mar 12, 2024
d435bda
use into over from
rnbguy Mar 12, 2024
6161f2c
clippy::redundant_closure_for_method_calls
rnbguy Mar 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy::derive_partial_eq_without_eq
  • Loading branch information
rnbguy committed Mar 11, 2024
commit 2084711306d156ba14153bf06124bbb194438fbf
2 changes: 1 addition & 1 deletion ibc-clients/ics07-tendermint/src/consensus_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use tendermint::{Hash, Time};
/// bypass Rust's orphan rules and implement traits from
/// `ibc::core::client::context` on the `ConsensusState` type.
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[derive(Clone, Debug, PartialEq, derive_more::From)]
#[derive(Clone, Debug, PartialEq, Eq, derive_more::From)]
pub struct ConsensusState(ConsensusStateType);

impl ConsensusState {
Expand Down
2 changes: 1 addition & 1 deletion ibc-core/ics02-client/types/src/height.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ impl core::fmt::Display for Height {
}

/// Encodes all errors related to chain heights
#[derive(Debug, Display, PartialEq)]
#[derive(Debug, Display, PartialEq, Eq)]
pub enum HeightError {
/// cannot convert into a `Height` type from string `{height}`
HeightConversion {
Expand Down
2 changes: 1 addition & 1 deletion ibc-testkit/src/testapp/ibc/clients/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ impl From<ConsensusStateType> for AnyConsensusState {
}
}

#[derive(Debug, Clone, From, PartialEq, ConsensusState)]
#[derive(Debug, Clone, From, PartialEq, Eq, ConsensusState)]
pub enum AnyConsensusState {
Tendermint(TmConsensusState),
Mock(MockConsensusState),
Expand Down