Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibc-clients/tendermint): disallow empty proof-specs and empty depth range in proof-specs #1104

Merged
merged 12 commits into from
Mar 1, 2024
Merged

fix(ibc-clients/tendermint): disallow empty proof-specs and empty depth range in proof-specs #1104

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ab0de4f
fix: disallow empty proof-specs and empty depth range in proof-specs
gr4yha7 Feb 28, 2024
279e388
chore: add changelog entry
gr4yha7 Feb 29, 2024
2e4f38b
nits
rnbguy Feb 29, 2024
84f18cc
test: add unit test
gr4yha7 Feb 29, 2024
486b6f8
chore: use default option (none)
gr4yha7 Feb 29, 2024
e6f3273
avoid new var
rnbguy Feb 29, 2024
821e848
nit in changelog
rnbguy Feb 29, 2024
711e58c
rm redundant clone
rnbguy Feb 29, 2024
efe40b3
Merge branch 'main' into gr4yha7/1100-fix-tendermint-proof_specs-check
rnbguy Feb 29, 2024
8a98508
propagate errors
rnbguy Mar 1, 2024
6741596
proof depth is unsigned
rnbguy Mar 1, 2024
8816158
use impl method
rnbguy Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add changelog entry
  • Loading branch information
@gr4yha7
gr4yha7 committed Feb 29, 2024
commit 279e38873e1ad2310900a1d9b8c17d59e70119bb
2 changes: 2 additions & 0 deletions .changelog/unreleased/bug-fixes/1100-fix-tendermint-empty-proof-specs-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ibc-client-tendermint-types] Validate the tendermint `ClientState` against empty proof-specs and empty proof-specs depth range.
([\#1100](https://github.com/cosmos/ibc-rs/issues/1100))