Skip to content

Ease frozen Height check in tendermint ClientState protobuf deserialization #1061

@Farhad-Shabani

Description

Summary

The current implementation, with the frozen height check in TryFrom causes issues for some hosts (see #1040), as it hampers the successful retrieval and deserialization of the ClientState during the standard process of converting raw bytes to proto type and then to domain type from the storage.
As within all ibc-rs handlers, we check the status of a client by performing the verify_is_active() on the retrieved ClientState, it’s safe to drop the frozen height check in this proto conversion.

Props to @riversyang for bringing this up in the first place, and thanks to @rnbguy for spotting it while diving into the ibc-testkit refactoring!

Version

=< 0.50.0

Metadata

Labels

A: bugAdmin: something isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions