Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename prometheus.yaml to prometheus.yml #3150

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Mar 8, 2023

Closes: #3106

Description

The docker-compose.yaml file is looking for a prometheus.yml for the prometheus container.
This PR renames the prometheus.yaml to prometheus.yml so that the docker-compose works correctly.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added A: bug Admin: something isn't working I: guide Internal: issues with the Hermes guide labels Mar 8, 2023
@ljoss17 ljoss17 requested review from romac and seanchen1991 March 8, 2023 09:27
@ljoss17 ljoss17 marked this pull request as ready for review March 8, 2023 09:27
@romac romac merged commit a2fb8c5 into master Mar 8, 2023
@romac romac deleted the luca_joss/prometheus-file-fix branch March 8, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working I: guide Internal: issues with the Hermes guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus.yaml/yml typo
2 participants