Fix ClientConsensusState query #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query of client consensus now distinguishes between query height and consensus height. Specifically: - `chain_height` is the height at which the query is made (can be 0 if the latest state on chain is queried). - `consensus_height` is the consensus height of the client running on this chain but it represents a height of the client's chain and should be used to construct the query path.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
========================================
Coverage ? 17.7%
========================================
Files ? 26
Lines ? 428
Branches ? 36
========================================
Hits ? 76
Misses ? 325
Partials ? 27 Continue to review full report at Codecov.
|
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
Closes: informalsystems#30 Query of client consensus now distinguishes between query height and consensus height. Specifically: - `chain_height` is the height at which the query is made (can be 0 if the latest state on chain is queried). - `consensus_height` is the consensus height of the client running on this chain but it represents a height of the client's chain and should be used to construct the query path.
romac
added a commit
that referenced
this pull request
May 8, 2023
ljoss17
pushed a commit
that referenced
this pull request
Nov 26, 2024
* for tx batching * remove send_tx * refactoring * fix error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #30
Description
Query of client consensus now distinguishes between query height
and consensus height.
Specifically:
chain_heightis the height at which the query is made(can be 0 if the latest state on chain is queried).
consensus_heightis the consensus height of the client running on this chainbut it represents a height of the client's chain and should be used to
construct the query path.
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer