Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query client consensus command #287

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Conversation

ancazamfir
Copy link
Collaborator

Closes: #286

Description

Added new query parameter for the epoch value.
Running the query against the gaiad/ go relayer setup:

$ rrly -c simple_config.toml query client consensus ibc0 ibconeclient 0 28
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/debug/relayer -c simple_config.toml query client consensus ibc0 ibconeclient 0 28`
     Options QueryClientConsensusOptions { client_id: ClientId("ibconeclient"), consensus_epoch: 0, consensus_height: 28, height: 0, proof: true }
[relayer/src/chain/cosmos.rs:63] "Todo: implement proof verification." = "Todo: implement proof verification."
client consensus state query result:  Tendermint(ConsensusState { timestamp: Time(2020-10-06T11:06:11.147301Z), root: CommitmentRoot([2, 140, 56, 156, 164, 1, 214, 81, 231, 130, 237, 6, 5, 85, 55, 52, 79, 27, 43, 202, 19, 49, 199, 249, 140, 146, 23, 88, 44, 151, 104, 246]), next_validators_hash: Hash::Sha256(702F9DF2C25EAC1CE7C19DC03E7AA10E3FD9BF1E65EE2A9B96DAEE3DD2E65FC5) })

@ancazamfir ancazamfir requested a review from romac as a code owner October 6, 2020 11:34
@ancazamfir ancazamfir self-assigned this Oct 6, 2020
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a suggestion but feel free to ignore it and merge this if you feel it's not worth the change.

modules/src/ics24_host/path.rs Outdated Show resolved Hide resolved
@ancazamfir ancazamfir merged commit a4acc6e into master Oct 7, 2020
@ancazamfir ancazamfir deleted the anca/query_consensus_bug branch October 14, 2020 09:07
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
* Add epoch to query client consensus

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query client consensus command fails
2 participants