Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Docker-based e2e jobs and everything related to Docker #2471

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Remove Docker-based e2e jobs and everything related to Docker #2471

merged 2 commits into from
Jul 27, 2022

Conversation

romac
Copy link
Member

@romac romac commented Jul 27, 2022 •
edited
Loading

Closes: #2190

Description

Remove the two Docker-based e2e jobs, and everything related to Docker, except for the Hermes release image in ci/release/hermes.Dockerfile.

These two jobs are already running via Nix within the Rust-based integration test suite so there is no need to keep them around anymore, especially since they've been causing issues on CI. See https://github.com/informalsystems/ibc-rs/issues/2190#issuecomment-1195573826

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from adizere July 27, 2022 07:57
soareschen
soareschen approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@soareschen soareschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth mentioning somewhere, perhaps in the e2e directory, that the Python E2E tests can be run with:

cargo test -p ibc-integration-test -- python_end_to_end_tests

adizere
adizere approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing PR

+ 2
- 15,663

agree with Soares' comment

@romac romac merged commit a1d86e7 into master Jul 27, 2022
@romac romac deleted the romac/2190-rm-docker branch July 27, 2022 09:10
@romac romac mentioned this pull request Aug 10, 2022
Closed
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@romac
Remove Docker-based e2e jobs and everything related to Docker (inform…
e8bec88 
…alsystems#2471)

* Remove Docker-based e2e jobs and everything related to Docker except for the Hermes release image

* Add README to e2e folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

@adizere adizere adizere approved these changes

@mzabaluev mzabaluev Awaiting requested review from mzabaluev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate the use of Nix towards making our CI Docker-free
3 participants
@romac @soareschen @adizere