Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added --overwrite flag to avoid errors when using dev-env #2437

Merged
merged 1 commit into from
Jul 20, 2022
Merged

added --overwrite flag to avoid errors when using dev-env #2437

merged 1 commit into from
Jul 20, 2022

Conversation

AlianBenabdallah
Copy link
Contributor

@AlianBenabdallah AlianBenabdallah commented Jul 19, 2022 •
edited
Loading

Closes: #2436

Description

adds --overwrite to hermes keys add commands

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@AlianBenabdallah AlianBenabdallah requested a review from adizere July 19, 2022 15:52
@romac romac merged commit e6620fb into master Jul 20, 2022
@romac romac deleted the ali/update_script branch July 20, 2022 07:56
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@AlianBenabdallah
added --overwrite flag to avoid errors when using dev-env (informalsy…
2b31218 
…stems#2437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scripts/dev-env needs an update
2 participants
@AlianBenabdallah @romac