Handshake verification logic #1878
Conversation
seanchen1991
requested review from
adizere,
ancazamfir and
romac
as code owners
| @@ -1196,10 +1197,17 @@ fn check_destination_connection_state( | |||
| || existing_connection.counterparty().connection_id() | |||
| == expected_connection.counterparty().connection_id(); | |||
|
|
|||
| // TODO check versions and store prefix | |||
| // https://github.com/informalsystems/ibc-rs/issues/1389 | |||
| let good_version = existing_connection.versions() == expected_connection.versions(); | |||
There was a problem hiding this comment.
Not sure about this, it's more like existing_connection.versions() is a subset of the expected_connection.versions(). Also it's not clear that the versions of the expected_connection are properly populated by caller here. Maybe it should get the versions on source and destination, and stuff the intersection in the expected_connection.
This code will work until a second connection version is introduced. It's also the case that we don't have a gRPC endpoint to query connection versions supported by a chain, currently hardcoded. Unless a new gRPC is provided, we will need to put the chain supported versions in the config file (similar story as for store prefix which is not queryable but this one we put it in the config file)
* Add checks for version and prefix for expected connections. * Add some doc comments. * Add changelog file. * Add more doc comments. * Remove `to_vec` call. * Improve changelog entry.
Closes: #1389
Description
Adds checks for
ConnectionEnd::versionsandCounterparty::prefixfields to thecheck_destination_connection_statemethod.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.