Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Updated changelog instructions #1644

Merged
merged 4 commits into from
Dec 7, 2021
Merged

BUG: Updated changelog instructions #1644

merged 4 commits into from
Dec 7, 2021

Conversation

fkneeland-figure
Copy link
Contributor

@fkneeland-figure fkneeland-figure commented Dec 3, 2021 •
edited by adizere
Loading

Closes: #1643

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

romac
romac reviewed Dec 6, 2021
View reviewed changes
.changelog/unreleased/bug/1634-update-unclog-instructions.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@adizere adizere marked this pull request as ready for review December 7, 2021 08:55
adizere
adizere approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did a minor change (b33ef3d) to fix the stale unclog examples, and added the new example in the correct section.

@adizere adizere merged commit ae364f9 into informalsystems:master Dec 7, 2021
@fkneeland-figure
Copy link
Contributor Author

Awesome! Thanks so much @adizere

hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@fkneeland-figure @romac @adizere
BUG: Updated changelog instructions (informalsystems#1644)
63900b1 
* updated changelog instructions

* Apply suggestions from code review

* Nits in the contrib document

Co-authored-by: Romain Ruetschi <romain.ruetschi@gmail.com>
Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac left review comments

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update instructions on running unclog
3 participants
@fkneeland-figure @romac @adizere