Restructure modules to align with ibc-go's structure
#1459
Conversation
seanchen1991
requested review from
adizere,
ancazamfir and
romac
as code owners
There was a problem hiding this comment.
This looks so fresh so clean! Thanks Sean for spearheading this. Restructuring it was long overdue and will help with future adoption and code hygiene.
Approved! If we also update the docs.rs documentation for crate ibc this will deserve a 0.8 release.
Before merging this PR, however, I think we should announce it to current downstream dependencies and get their ACK (at the least), who will be affected by this breaking change. Comes to mind:
- @DaviRain-Su
- @yito88
- @hu55a1n1
- @andynog who can help inform e.g., Octopus, Anoma, and other dependencies of
ibcand keep them in the loop
|
Nevermind, it's not a big problem keeping it named |
Updating the |
…s into restructure-to-ibc-go Mergin in upstream changes.
…ms#1459) * Move ics modules into Client, Applications, and Core modules * Fix broken imports in tests * Fix some more broken imports in tests * Fix broken imports in `telemetry`, `relayer`, and `relayer-cli` * Run cargo fmt * Fix more broken links * Add changelog entry * Update modules/lib.rs to reflect new directory structure * Remove conflict marker in gitignore * Flesh out lib.rs documentation
Address: #1436
Description
This PR adds
modules/src/core,modules/src/clients, andmodules/src/relayerdirectories (modules/src/applicationsalready existed) and moves all of the ICS modules into the appropriate directories in order to adhere to the breakdown prescribed in the spec.The
modules/src/mockdirectory and the standalone files located inmodules/srchaven't been touched, though we should also figure out whether there are more appropriate locations for them and what those are.For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.