Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gm: Add option to download chain binary from a URL #1371

Merged
merged 4 commits into from
Sep 21, 2021
Merged

gm: Add option to download chain binary from a URL #1371

merged 4 commits into from
Sep 21, 2021

Conversation

greg-szabo
Copy link
Member

@greg-szabo greg-szabo commented Sep 21, 2021 •
edited
Loading

Closes: #XXX

Description

This is a new feature (with a version bump) that adds the possibility to use a web URL to define a chain binary. This will be very useful in CI environments where some parts of the test environment are not created on the spot.

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac changed the title Greg/gm features gm: Add option to download chain binary from a URL Sep 21, 2021
@greg-szabo greg-szabo merged commit 563102c into master Sep 21, 2021
@greg-szabo greg-szabo deleted the greg/gm-features branch September 21, 2021 18:25
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@greg-szabo
gm: Add option to download chain binary from a URL (informalsystems#1371
c175d75 
)

* gm 0.0.9 - binary URL support

* Added some preliminary JSON work and some fixes

* Added changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greg-szabo @adizere