Skip to content

Some (g)RPC queries are missing proper pagination #811

Closed
@ancazamfir

Description

@ancazamfir

Crate

relayer

Summary of Bug

all (g)RPC queries that return multiple items are missing proper pagination

Version

Steps to Reproduce

  • Send > 100 packets:
    $ hermes tx raw ft-transfer ibc-0 ibc-1 transfer channel-0 9999 15 -n 500
  • Query packet commitments will return less than 500
    hermes query packet unreceived-packets ibc-1 ibc-0 transfer channel-0

Found this while I was debugging why hermes start doesn't clear all packets on start.

Acceptance Criteria

All gRPC queries that return collections should be looked at. Here is a list (needs to be updated after we release v0.2.0:

  • query_clients
  • query_client_connections - proto QueryClientConnectionsRequest doesn't have pagination
  • query_connections
  • query_connection_channels
  • query_channels
  • query_packet_commitments
  • query_unreceived_packets- proto QueryUnreceivedPacketsRequest doesn't have pagination - not needed as we ask for specific sequences
  • query_packet_acknowledgements
  • query_unreceived_acknowledgements - proto QueryUnreceivedAcksRequest doesn't have pagination - not needed as we ask for specific sequences
  • query_consensus_states

This is using tendermint rpc and should also be fixed:

  • query_txs

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

I: rpcInternal: related to (g)RPC

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions