Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intelligent Batch Packet Broadcasting #3443

Open
5 tasks
Tracked by #3437
nik-suri opened this issue Jun 26, 2023 · 0 comments
Open
5 tasks
Tracked by #3437

Intelligent Batch Packet Broadcasting #3443

nik-suri opened this issue Jun 26, 2023 · 0 comments
Assignees
Labels
O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@nik-suri
Copy link

Summary

Intelligently compute number of packets to batch broadcast based on max_gas.

Problem Definition

It looks like when there are a lot of pending packets the relayer will pull and try to broadcast up to 50 packets at a time. However, if the max_gas in the config is lower than the gas requirement to broadcast all these packets, the transaction will fail and the relayer doesn’t seem to relay those pending packets, so they’re effectively stuck.

Proposal

It’s not the greatest fix to have to adjust the max_gas requirement — is there some config for max packets to relay at once? Not sure if, after the batch broadcast fails, hermes then tries to relay the packets 1 by 1? A helpful feature that still does batch broadcasting could calculate the proper number of packets to batch broadcast that’s within the max_gas config and relay that amount.

Acceptance Criteria

Either a feature is implemented to support this, or there is a workaround we don't yet know of!


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 26, 2023
@seanchen1991 seanchen1991 self-assigned this Jun 27, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes Jun 27, 2023
@seanchen1991 seanchen1991 added this to the v1.7 milestone Jun 27, 2023
@seanchen1991 seanchen1991 added O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product labels Jul 24, 2023
@romac romac modified the milestones: v1.7, v1.8 Aug 31, 2023
@romac romac modified the milestones: v1.8, v1.9 Nov 13, 2023
@adizere adizere modified the milestones: v1.9, v1.10 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
Status: 📥 Todo
Development

No branches or pull requests

4 participants