Skip to content

Fix email address typo #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix email address typo #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7f60bb
Fix adress and calback typos
strosek Feb 9, 2023
8673d80
Fix email addresses typo
strosek Feb 9, 2023
7d2a84a
Add spelling exceptions
strosek Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 43 additions & 34 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,50 +11,59 @@
"misc"
],
"words": [
"infobip",
"ibsso",
"pydantic",
"formdata",
"AYΣTHPO",
"AΘHNAIΩN",
"AΠOΦAΣH",
"EINAI",
"EKKΛHΣIAΣ",
"EMΠAPΓKO",
"ENROUTE",
"EΠIBAΛEI",
"KAΘOΛIKO",
"Kilic",
"Lozina",
"Luka",
"MEΓAPIKO",
"Snyk",
"WABA",
"aabe",
"conint",
"conlist",
"defaultplaceholders",
"dtmf",
"formdata",
"ibsso",
"ijkl",
"infobip",
"intermediatereport",
"msisdn",
"webrtc",
"testenv",
"WABA",
"preserverecipients",
"pydantic",
"replyto",
"setuptools",
"Snyk",
"Luka",
"Kilic",
"Lozina",
"somexternal",
"templateid",
"testenv",
"trackclicks",
"trackopens",
"webrtc",
"Αθηναίων",
"ΓNΩΣTH",
"ΓYPΩ",
"ΔHMOY",
"Εκκλησίας",
"Μεγαρικό",
"ψήφισμα",
"είναι",
"γνωστή",
"ΠIΘANON",
"ΨHΦIΣMA",
"απόφαση",
"Εκκλησίας",
"αυστηρό",
"γνωστή",
"δήμου",
"Αθηναίων",
"είναι",
"εμπάργκο",
"επιβάλει",
"αυστηρό",
"καθολικό",
"εμπάργκο",
"aabe",
"MEΓAPIKO",
"ΨHΦIΣMA",
"EINAI",
"ΓNΩΣTH",
"AΠOΦAΣH",
"EKKΛHΣIAΣ",
"ΔHMOY",
"AΘHNAIΩN",
"ΠIΘANON",
"ΓYPΩ",
"EΠIBAΛEI",
"AYΣTHPO",
"KAΘOΛIKO",
"EMΠAPΓKO",
"ijkl"
"ψήφισμα"
],
"flagWords": [],
"patterns": [
Expand Down
4 changes: 2 additions & 2 deletions infobip_channels/email/channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from infobip_channels.email.models.body.update_tracking_events import (
UpdateTrackingEventsMessageBody,
)
from infobip_channels.email.models.body.validate_email_adresses import (
from infobip_channels.email.models.body.validate_email_addresses import (
ValidateEmailAddressesMessageBody,
)
from infobip_channels.email.models.path_parameters.delete_existing_domain import (
Expand Down Expand Up @@ -80,7 +80,7 @@
from infobip_channels.email.models.response.update_tracking_events import (
UpdateTrackingEventsResponse,
)
from infobip_channels.email.models.response.validate_email_adresses import (
from infobip_channels.email.models.response.validate_email_addresses import (
ValidateEmailAddressesResponse,
)

Expand Down
0 ...il/models/body/validate_email_adresses.py → ...l/models/body/validate_email_addresses.py
View file
Open in desktop
File renamed without changes.
0 ...odels/response/validate_email_adresses.py → ...dels/response/validate_email_addresses.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/email/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from infobip_channels.email.models.body.update_tracking_events import (
UpdateTrackingEventsMessageBody,
)
from infobip_channels.email.models.body.validate_email_adresses import (
from infobip_channels.email.models.body.validate_email_addresses import (
ValidateEmailAddressesMessageBody,
)

Expand Down
2 changes: 1 addition & 1 deletion tests/email/models/test_validate_email_adresses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest
from pydantic.error_wrappers import ValidationError

from infobip_channels.email.models.body.validate_email_adresses import (
from infobip_channels.email.models.body.validate_email_addresses import (
ValidateEmailAddressesMessageBody,
)

Expand Down
6 changes: 3 additions & 3 deletions tests/sms/models/test_send.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ def test_when_destinations_to_is_invalid__validation_error_is_raised(destination
)


@pytest.mark.parametrize("calback_data", [{}, get_random_string(4001)])
def test_when_calback_data_to_is_invalid__validation_error_is_raised(calback_data):
@pytest.mark.parametrize("callback_data", [{}, get_random_string(4001)])
def test_when_callback_data_to_is_invalid__validation_error_is_raised(callback_data):
with pytest.raises(ValidationError):
GenerateSMSMessageBodyFactory.build(
**{
"messages": [
{
"callbackData": calback_data,
"callbackData": callback_data,
"destinations": [{"to": "41793026727"}],
}
]
Expand Down
6 changes: 3 additions & 3 deletions tests/sms/models/test_send_binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def test_when_destinations_to_is_invalid__validation_error_is_raised(destination
)


@pytest.mark.parametrize("calback_data", [{}, get_random_string(4001)])
def test_when_calback_data_is_invalid__validation_error_is_raised(calback_data):
@pytest.mark.parametrize("callback_data", [{}, get_random_string(4001)])
def test_when_callback_data_is_invalid__validation_error_is_raised(callback_data):
with pytest.raises(ValidationError):
GenerateBinarySMSMessageBodyFactory.build(
**{
Expand All @@ -66,7 +66,7 @@ def test_when_calback_data_is_invalid__validation_error_is_raised(calback_data):
"esmClass": 0,
"hex": "54 65 73 74 20 6d 65 73 73 61 67 65 2e",
},
"callbackData": calback_data,
"callbackData": callback_data,
"destinations": [{"to": "41793026727"}],
}
]
Expand Down