Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact passwords in Client's Debug implementation #106

Merged
merged 4 commits into from
Dec 22, 2021

Conversation

msrd0
Copy link
Collaborator

@msrd0 msrd0 commented Dec 22, 2021

Description

Fixes #103

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy
    • with reqwest feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,reqwest-client -- -D warnings
    • with surf feature: cargo clippy --manifest-path influxdb/Cargo.toml --all-targets --no-default-features --features use-serde,derive,hyper-client -- -D warnings
  • Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@msrd0 msrd0 force-pushed the client-debug-redact-password branch from a56c8ea to 58bf40e Compare December 22, 2021 10:26
@msrd0
Copy link
Collaborator Author

msrd0 commented Dec 22, 2021

Those clippy lints weren't introduced in this PR

Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@msrd0 msrd0 merged commit 0f20994 into main Dec 22, 2021
@msrd0 msrd0 deleted the client-debug-redact-password branch December 22, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Credentials In Debug Output of Client
2 participants