Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable extracting tag values from MQTT topics #9995

Merged
merged 15 commits into from
Nov 23, 2021
Merged

feat: enable extracting tag values from MQTT topics #9995

merged 15 commits into from
Nov 23, 2021

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Oct 25, 2021 •
edited
Loading

Required for all PRs:

resolves #2070 #10049

Allows parsing of mqtt topic into tags, metrics, and measurements

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 25, 2021
@srebhan srebhan mentioned this pull request Nov 3, 2021
Closed
@sjwang90
Copy link
Contributor

sjwang90 commented Nov 3, 2021

Resolves #10049

@MyaLongmire @sspaink
fix: readme spelling
3e7170f 
Co-authored-by: Sebastian Spaink <3441183+sspaink@users.noreply.github.com>
@MyaLongmire MyaLongmire marked this pull request as ready for review November 16, 2021 18:15
srebhan
srebhan reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MyaLongmire nice work! I have some suggestions on the code... Happy to discuss those. :-)

plugins/inputs/mqtt_consumer/README.md Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/README.md Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/README.md Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/README.md Show resolved Hide resolved
plugins/inputs/mqtt_consumer/README.md Show resolved Hide resolved
plugins/inputs/mqtt_consumer/mqtt_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/mqtt_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/mqtt_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/mqtt_consumer.go Outdated Show resolved Hide resolved
plugins/inputs/mqtt_consumer/mqtt_consumer.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Nov 18, 2021
@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/mqtt and removed fix pr to fix corresponding bug labels Nov 18, 2021
MyaLongmire and others added 5 commits November 19, 2021 17:59
@MyaLongmire @srebhan
fix: spelling
45e5f2c 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@MyaLongmire @srebhan
fix: grammar
932a159 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@MyaLongmire @srebhan
fix: markdown
8d962b5 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@MyaLongmire @srebhan
chore: make more readable parsing
e4bd175 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@MyaLongmire @srebhan
fix: remove an indentation level
a925421 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@samhld
Copy link
Contributor

samhld commented Nov 22, 2021 •
edited
Loading

[Deleted comment]

User error

@telegraf-tiger
Copy link
Contributor

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm freebsd_amd64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_armv7.tar.gz
armhf.deb i386.rpm freebsd_i386.tar.gz
i386.deb ppc64le.rpm linux_amd64.tar.gz
mips.deb s390x.rpm linux_arm64.tar.gz
mipsel.deb x86_64.rpm linux_armel.tar.gz
ppc64el.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@samhld
Copy link
Contributor

samhld commented Nov 22, 2021

LGTM!

srebhan
srebhan approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for working on this @MyaLongmire!

plugins/inputs/mqtt_consumer/README.md Show resolved Hide resolved
plugins/inputs/mqtt_consumer/README.md Show resolved Hide resolved
@MyaLongmire
Copy link
Contributor Author

Thanks for the quick review @srebhan and @samhld! I appreciate your input.

@MyaLongmire MyaLongmire merged commit b89ef94 into master Nov 23, 2021
@MyaLongmire MyaLongmire deleted the mqtt-extracting-tags branch November 23, 2021 15:20
reimda pushed a commit that referenced this pull request Dec 1, 2021
@MyaLongmire @reimda
feat: enable extracting tag values from MQTT topics (#9995)
5b6f328
@srebhan srebhan mentioned this pull request Dec 7, 2021
Closed
3 tasks
@MyaLongmire MyaLongmire mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspaink sspaink sspaink left review comments

@samhld samhld samhld left review comments

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/mqtt feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MyaLongmire @sjwang90 @samhld @sspaink @srebhan