Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set the default value correctly #9980

Merged
merged 7 commits into from
Nov 8, 2021
Merged

fix: Set the default value correctly #9980

merged 7 commits into from
Nov 8, 2021

Conversation

since1986
Copy link
Contributor

@since1986 since1986 commented Oct 22, 2021 •
edited
Loading

The smi path exception was thrown in Init() (previously thrown in Gather()), the purpose of this is to find the problem earlier

resolves #9979

fix: Set the default value correctly
42fbbb8 
BREAKING CHANGE: The smi path exception was thrown in Init() (previously thrown in Gather()), the purpose of this is to find the problem earlier
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 22, 2021
@since1986 since1986 mentioned this pull request Oct 22, 2021
Closed
@since1986
Copy link
Contributor Author

since1986 commented Oct 22, 2021 •
edited
Loading

⚠⚠⚠ Note that this PR(9980) has BREAKING CHANGES, which may cause version compatibility issues
backward compatibility has been achieved

powersj
powersj suggested changes Oct 22, 2021
View reviewed changes
plugins/inputs/nvidia_smi/nvidia_smi.go Outdated Show resolved Hide resolved
plugins/inputs/nvidia_smi/nvidia_smi.go Show resolved Hide resolved
@since1986 since1986 requested a review from powersj October 25, 2021 03:23
Hipska
Hipska suggested changes Oct 27, 2021
View reviewed changes
plugins/inputs/nvidia_smi/nvidia_smi.go Outdated Show resolved Hide resolved
plugins/inputs/nvidia_smi/nvidia_smi.go Outdated Show resolved Hide resolved
@Hipska Hipska added plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins area/nvidia labels Oct 27, 2021
@since1986 since1986 requested review from Hipska and srebhan November 3, 2021 09:46
srebhan
srebhan reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the update @since1986! Just one small comment left... :-)

plugins/inputs/nvidia_smi/nvidia_smi.go Outdated Show resolved Hide resolved
@since1986 since1986 requested a review from srebhan November 3, 2021 12:43
srebhan
srebhan reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Only some spaces left. Maybe set your editor to "trim trailing spaces"?

plugins/inputs/nvidia_smi/README.md Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 3, 2021

⚠️ This pull request increases the Telegraf binary size by 1.08 % for linux amd64 (new size: 132.1 MB, nightly size 130.7 MB)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm freebsd_amd64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_armv7.tar.gz
armhf.deb i386.rpm freebsd_i386.tar.gz
i386.deb ppc64le.rpm linux_amd64.tar.gz
mips.deb s390x.rpm linux_arm64.tar.gz
mipsel.deb x86_64.rpm linux_armel.tar.gz
ppc64el.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@srebhan
Copy link
Member

srebhan commented Nov 3, 2021

@since1986 can you please update the PR description above as we now don't face a breaking change I think?

srebhan
srebhan approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your nice work @since1986!

@srebhan srebhan self-assigned this Nov 3, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 3, 2021
@srebhan
Copy link
Member

srebhan commented Nov 3, 2021

@since1986 for fixing the CI issue, try rebasing on the latest master. It would help us to understand what to do in similar cases.

Anyway @powersj I think it's save to merge the PR despite the CI errors as those are only formatting issues in the README...

@powersj powersj merged commit 0133f12 into influxdata:master Nov 8, 2021
powersj pushed a commit that referenced this pull request Nov 17, 2021
@since1986 @powersj
fix: Set the default value correctly (#9980)
e8678fb 
(cherry picked from commit 0133f12)
VladislavSenkevich pushed a commit to gwos/telegraf that referenced this pull request Nov 23, 2021
@since1986
fix: Set the default value correctly (influxdata#9980)
fbf69c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

@Hipska Hipska Awaiting requested review from Hipska

Assignees

@srebhan srebhan

Labels
area/nvidia fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The default value is not set correctly (nvidia_smi plugin)
4 participants
@since1986 @srebhan @Hipska @powersj