Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate to cloud.google.com/go/monitoring/apiv3/v2 #9880

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Oct 7, 2021

cloud.google.com/go/monitoring/apiv3 is deprecated and replaced by cloud.google.com/go/monitoring/apiv3/v2, monitoring.MetricProjectPath was also deprecated and replaced with fmt.Sprintf("projects/%s", s.Project). Both of these deprecation's were reported by the linter staticcheck.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 7, 2021
@sspaink sspaink added the area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver label Oct 7, 2021
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only question if mod.go doesn't need to be updated?

@sspaink
Copy link
Contributor Author

sspaink commented Oct 7, 2021

@Hipska thanks for reviewing this, I was also surprised there wasn't a go.mod change but looks like v2 is imported by cloud.google.com/go/monitoring v0.2.0 as well.

@sspaink sspaink merged commit 15753a6 into master Oct 7, 2021
@sspaink sspaink deleted the migratemonitoringv2 branch October 7, 2021 19:48
reimda pushed a commit that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants